Run as Node program leaves launching Job behind at 37% #581

Activity

1. mickaelistria commented on Dec 11, 2020

   

   mickaelistria

   on Dec 11, 2020

   Contributor

   More actions

   Thanks for the report. I can easily reprodce it.
2. mickaelistria commented on Dec 11, 2020

   

   mickaelistria

   on Dec 11, 2020

   Contributor

   More actions

   Here is a test that reproduces this issue

   	@Test
   	public void testNodeRunDoesntLeaveProgressReport()
   			throws CoreException, IOException, OperationCanceledException, InterruptedException {
   		IProject project = ResourcesPlugin.getWorkspace().getRoot().getProject("someProject");
   		project.create(null);
   		project.open(null);
   		IFile jsFile = project.getFile("hello.js");
   		jsFile.create(new ByteArrayInputStream(new byte[0]), true, null);
   		new NodeRunDebugLaunchShortcut().launch(new StructuredSelection(jsFile), ILaunchManager.RUN_MODE);
   		DisplayHelper.sleep(500);
   		Job launchJob = Arrays.stream(ProgressManager.getInstance().getJobInfos(false)) //
   				.map(JobInfo::getJob) //
   				.filter(job -> job.getName().startsWith("Launching")) //
   				.filter(job -> job.getState() == Job.RUNNING) //
   				.findFirst().get();
   		launchJob.join(500000, null);
   		assertEquals(Job.NONE, launchJob.getState(), "Job not completed");
   	}

   I could track that down to LSP4E, in DSPDebugTarget#initialize, the call to getDebugProtocolServer().launch(dspParameters) returns a never ending future.
3. mickaelistria

   added

   upstream-lsp4e

   on Dec 11, 2020
4. mickaelistria commented on Dec 11, 2020

   

   mickaelistria

   on Dec 11, 2020

   Contributor

   More actions

   This is indeed an upstream issue https://git.eclipse.org/r/c/lsp4e/lsp4e/+/173717 attempts to fix that.
5. acarstoiu commented on Dec 18, 2020

   

   acarstoiu

   on Dec 18, 2020

   More actions

   Just for the record, this issue was discussed in #330 and also reported in #455.
6. mickaelistria commented on Feb 18, 2021

   

   mickaelistria

   on Feb 18, 2021

   Contributor

   More actions

   Duplicate of #551 , let's close.
7. mickaelistria

   closed this as completedon Feb 18, 2021
8. mickaelistria commented on Feb 18, 2021

   

   mickaelistria

   on Feb 18, 2021

   Contributor

   More actions

   Duplicate of #551 , let's close.