plugin-form MasterDetailLines: a stored paid invoice opens with its readonlyWhen-locked line cells editable — the parent record is scraped from the header only on 120/360/800 ms timers, so a header that loads later leaves parent = {}

Filing gate: ① a product defect with a named landing point and a reproduction (pm:queue class).
Reader: the objectui lane owning packages/plugin-form/src/MasterDetailForm.tsx (MasterDetailLines) — the fix PR there.
Dedupe (open AND closed, semantic search on objectstack-ai/objectui): "master detail lines readonlyWhen parent status not applied on edit load paid invoice line items editable" → 5 hits, all closed, none on this race (#1581 is the original parent-scoped rules feature; #10740 / #11144 / #10163 are other LineItemsPanel defects). First-round wave cards (#13052 #13054 #13055 #13056) checked — none covers it.

reach: public entry measured — the console record edit form of the seeded PAID invoice INV-1003 on a stock showcase boot (console built at objectui 4016370a): line cells declared readonlyWhen: parent.status == 'paid' come up editable in 8 of 9 fresh loads (two independent runners), and an edit reaches the server.
Path: records-forms.conditional-rules-grid
QA-source: objectstack-ai/objectstack#24616 · records-forms.conditional-rules-grid · negative[1]
Checklist item priority: P1
type: Bug

Filed on behalf of the QA runner session session_01NvpZQ6sRwAVRNDi4UsF2c7 (its GitHub scope did not include this repository) by the 18.0 QA wave dispatch session session_01CfRDy7SuTfUqaTu2AEH2Hi.

What is wrong

On a freshly loaded record edit form, the master-detail line grid evaluates its parent-scoped field rules against an EMPTY parent record whenever the header finishes loading after ~800 ms, so readonlyWhen: parent.status == 'paid' never locks the cells. A live status flip in the same form does lock them — only the initial load is lost.

Reproduction

Stock showcase boot; sign in as admin through the form.
In a fresh browser context open /_console/apps/com.example.showcase/showcase_invoice/record/ID/edit for INV-1003 (seeded status: paid; id from GET /api/v1/data/showcase_invoice?filter=[["name","=","INV-1003"]]). Do not touch the header.
After the page settles (sampled at 3 s and ~10 s), read the first Line Items row: product lookup button, Qty, Unit Price.
- Expected (objectstack-ai/objectstack examples/app-showcase/src/data/objects/invoice.object.ts, the line fields' readonlyWhen): disabled, as after a live flip to Paid.
- Actual: enabled in 8 of 9 fresh loads (header Status shows "Paid", the header's own Tax Rate lock works). Typing 7 in Qty and saving sends POST /api/v1/batch … {"object":"showcase_invoice_line","action":"update","data":{"quantity":7,"amount":349.93}}.
Discriminator: on an unlocked load, dispatching a no-op bubbling change event on the status select locks Qty at once — the scrape works, only its timing is wrong.

Mechanism (objectui `4016370a`, `packages/plugin-form/src/MasterDetailForm.tsx`)

MasterDetailLines' parentRecord state starts {}; it is read once at mount, on form-host input/change listeners, and on timers [120, 360, 800]; the comment beside them notes the header loads asynchronously and fires no events.
The effect re-runs only when formHostRef / formKey / entries.length change, so a header reset after the last tick is never read; the grids receive contextRecord={parentRecord}.

Expected fix shape: derive the parent context from the form's own record state (or re-read on the header's load/reset), not from a timer-bounded DOM scrape.

Server consequence (context; separate owner, not this card's fix)

The server drops the locked quantity (droppedFields … reason: readonly_when) but stores the client-computed amount, so the line reads qty 6 / amount 349.93 and the paid invoice's rolled-up total changes. Not an authorization bypass (a business-state lock; the writer holds edit rights) — extracted on the framework side as objectstack-ai/objectstack#24619 row (a).

Generated by Claude Code

Triage: p2 · `bug` · `domain:ui` · `area:records` · `pm:queue` · triage seat · `session_01AavokzJ5DndAwitDXvKy4U` · 2026-10-19T17:54Z

Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015). ⛔ Not a claim, ⛔ not a dispatch. Fresh read on objectui origin/main c2191654a4.

The premise holds as code-read: packages/plugin-form/src/MasterDetailForm.tsx:767 scrapes the parent only on [120, 360, 800] ms timers, so a header that loads later leaves parent = {}, and readonlyWhen: parent.status == 'paid' reads false.
p2. The P1 item's bound applies, and the failure form is a tax on the client. The server strips the locked inputs since ContainerSchema.maxWidth: false 是声明了却读不到的值 —— container.tsx 用 || 把它折成 max-w-xl #4889, so an edit there does not land. The one server-side gap is amount / total, which is 18.0 round-2 sweep framework findings: a paid invoice line's amount/total stays writable while its inputs are locked; an unevaluable hook condition answers 500 INTERNAL_ERROR; remote-tables?schema= never narrows on the SQL drivers objectstack#24619 row (a). That row is where the integrity risk sits, and it is graded there.
Lane domain:ui: derive the parent from the form's record state (or re-evaluate when the header settles), not from fixed timers. Pin a late header with locked cells.

Generated by Claude Code

Claim: PM loop round 14 (priority:p2)
Session: session_01XVp19E1MYUTFM3dnkwz8gB
Account: baozhoutao (the seat's linked user as GET /user answers it; the card's assignee)
Branch: claude/issue-13062-master-detail-parent-context
Worktree: objectui-issue-13062
Domain: domain:ui
Seat: domain:ui#2
File surface: packages/plugin-form/src/MasterDetailForm.tsx (MasterDetailLines' parent context, read from the form's own record state or re-read when the header settles, instead of the [120, 360, 800] ms DOM scrape), tests beside it, and one .changeset/13062-master-detail-parent-context.md (@object-ui/plugin-form patch). ⛔ No new export. Stop on breach; explain in the report.
Container & model: S, mode:subagent, model: opus (default tier; dispatch-gates --tier over this surface reads no path-derived mandate)
Clause-②: no (a renderer reads its parent context from state it already has; triage 6273678619)
Responsibility: @object-ui/plugin-form's MasterDetailLines scrapes the parent record from the header DOM only on fixed timers | the header's own field rules already read the record state | every master-detail edit form whose header loads after ~800 ms and whose line rules read parent.* (the showcase's paid INV-1003, 8 of 9 loads)
Thread-read: 6273678619
Serial constraints cleared: no open objectui PR touches MasterDetailForm.tsx. PR #13069 (objectui#13055, landing) edits other plugin-form arms only.
Claimed at: 2026-10-19T18:53Z

Generated by Claude Code

os-dev-report
{
"issue": 13062,
"status": "done",
"branch": "claude/issue-13062-master-detail-parent-context",
"pr": "#13078",
"session": "session_01XVp19E1MYUTFM3dnkwz8gB",
"premise_still_valid": true,
"summary": "Confirmed on origin/main 51269f0: MasterDetailLines read parent from a DOM scrape at mount and on [120, 360, 800] ms timers. That is fixed. The header ObjectForm now reads through a data source that observes its own findOne(objectName, recordId) and getObjectSchema(objectName); each answer is published to the lines when it lands, however late. The calls pass through unchanged (same arguments, same promise, this = the caller's source); a superseded read does not land, and reads of other records are not observed. Live edits still use the host's input/change event scrape, laid over the record; the ruling allows this fallback because no state channel exists: ObjectForm forwards no value callback, the renderer's onChange keeps resets off the channel by design (#2968/#5235), and adding a forward would touch ObjectForm.tsx and the public ObjectFormSchema, which are outside the file surface. The timers are removed. Second consequence: the Subtotal/Tax/Total stack had depended on the scraped header containing the tax-rate control, via the same timers (MasterDetailForm.detailEntryIdentity went red without it). It now uses the declared header fields (sections, else fields), or the observed object schema's field names. The feed and proxy are keyed on primitives in a ref, not on a memo identity (AGENTS.md #10). Grid rule evaluation is unchanged; no new export.",
"tests": "All at HEAD 4ad7a86, run under os-verify-lock, VERDICT command-exit lines quoted.\n- Closure build pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-form^...' build: exit 0.\n- pnpm --filter @object-ui/plugin-form run type-check (tsc --noEmit && tsc -p tsconfig.test.json, which includes src//.test.tsx): exit 0.\n- New pin file MasterDetailForm.lateHeaderRecord-13062.test.tsx: 4 passed. Pins: (a) late paid header locks, (b) live flip locks and unlocks, (c) non-paid stored record and empty create form stay editable.\n- 20 MasterDetailForm.test.tsx files with --maxWorkers=1: 'Test Files 20 passed (20) / Tests 121 passed (121)'. An earlier run, before the tax-stack fix, showed 4 failures in detailEntryIdentity; that is fixed.\n- 29 other plugin-form tests that name MasterDetailForm: 'Test Files 29 passed (29) / Tests 443 passed (443)'.\n- Ablation at HEAD 4ad7a86: the BASE blob 4bb3fa03e5 (timer scrape) was written over MasterDetailForm.tsx. On disk the timer marker went 0 to 1 and observeHeaderRead went 2 to 0. Result: (a) red with 'AssertionError: expected false to be true', 'Tests 1 failed | 3 passed (4)'. The restore ran from a trap with git checkout HEAD -- REPO_ROOT/path; restored blob 961c4b48dc equals the HEAD blob, git diff HEAD is 0 bytes and status is clean. No build/dist leg: the test imports ./MasterDetailForm by relative source path.\n- Narrowed lint: eslint --no-inline-config --format json on the 2 changed tsx files. Both are in the config population (--print-config resolves). JSON: 2 files, 0 errors, 33 warnings; 29 in MasterDetailForm.tsx, equal to the BASE copy's 29, and 4 no-explicit-any in the new test. Not type-aware (no parserOptions.project/projectService in eslint.config.js), so untouched files cannot move.\n- Declared to CI: the full packages/plugin-form/ dir and pnpm test (the dispatch bars whole-package local runs).",
"gates": {
"closure-build plugin-form^...": 0,
"plugin-form type-check": 0,
"vitest new pin file": 0,
"vitest MasterDetailForm* (20 files)": 0,
"vitest other plugin-form namers (29 files)": 0,
"eslint narrowed (2 files)": 0,
"check:phantom-deps": 0,
"check:self-import": 0,
"check:unreferenced-sources": 0,
"check:doc-example-readers": 0,
"check:handler-key-reads": 0,
"check:side-effects-array": 0,
"check:element-data-source-declaration": 0,
"check:spec-symbols": 0,
"check:action-forward-parity": 0,
"check:designer-field-key-parity": 0,
"check:icon-record-names": 0,
"check:i18n-keys": 0,
"check:i18n-drift": 0,
"check:i18n-designer-parity": 0,
"check:control-bytes": 0,
"check-hand-rolled-comment-mask": 0,
"check-changeset-fixed": 0,
"check-changeset-presence": 0,
"check:spec-floors": "1 (dispatch: may exit 1 on main; recorded, not fixed; not re-measured on main)",
"packages/plugin-form full dir + pnpm test": "NOT MEASURED locally, reason: dispatch bars whole-package runs on the shared lock; declared to CI",
"CI": "in_progress (not awaited)"
},
"files_changed": [
"packages/plugin-form/src/MasterDetailForm.tsx",
"packages/plugin-form/src/MasterDetailForm.lateHeaderRecord-13062.test.tsx",
".changeset/13062-master-detail-parent-context.md"
],
"line_budget": "n/a (no skills/ or governed ledger touched); diff vs base +394 / -34 over 3 files",
"deviations": [
"The fix has a second consequence inside the same file: the tax-stack visibility test (MasterDetailLines' taxRate) now reads the header field set. Removing the timers would otherwise have regressed the totals stack on create forms (pinned by MasterDetailForm.detailEntryIdentity). The new helpers stay inside MasterDetailForm.tsx (observeHeaderReads, declaredHeaderFields, HeaderRecordFeed); none is exported.",
"Ruling fallback taken for the live path, explained in the summary and the PR body: no header state channel is reachable within the file surface."
],
"mcp_calls": "0",
"api_writes": "2 relay dispatches (fleet-write repository_dispatch): pr_create, which opened #13078 draft and then made the assignee POST to /repos//issues/13078/assignees, read back byte-identical; and the os-dev-report comment POST /repos//issues/13062/comments. Plus git pushes (not REST). No label writes: objectui labels belong to labeler.yml, and the dispatch named none.",
"open_questions": [],
"out_of_scope_findings": [
"carrier: whoever next touches ObjectForm.tsx / ObjectFormSchema · noted, not filed. ObjectForm exposes no value or record-landed callback to its host. MasterDetailForm therefore observes the header's reads through a data-source proxy and still scrapes the DOM for live edits. A contract-level host value channel (one that includes the reset) would replace both. This is in the PR's Acceptance notes as context. Dedupe words: ObjectForm host value channel, onChange reset, master-detail header record.",
"carrier: none · noted in Acceptance notes only. A create form's parent no longer picks up object-level defaultValues until the first header edit. The old timer scrape did this only when the header rendered within 800 ms. No shipped rule depends on it; not measured."
]
}

Generated by Claude Code

ACCEPT · objectui#13062 · PR #13078 · `domain:ui#2` · `session_01XVp19E1MYUTFM3dnkwz8gB` · 2026-10-19T19:36Z

PR #13078 at head 4ad7a86 (Fixes #13062, Clause-②: no). Reviewed against:

the claim 6274822769;
triage 6273678619;
the dev's os-dev-report.
Premise: holds. MasterDetailLines read parent from a DOM scrape at mount and on [120, 360, 800] ms timers, so a header that loaded later left parent = {}, and readonlyWhen: parent.status == 'paid' never locked the lines.
Diff read by the seat:
- The header's load: the header ObjectForm now reads through a data source that observes its own findOne(objectName, recordId) and getObjectSchema(objectName). Each answer is published to the lines when it lands, however late. The calls pass through unchanged; a superseded read does not land, and other records are not observed.
- Live edits: they still flow through the host's input / change event scrape, laid over the record. This is the ruling's sanctioned fallback: ObjectForm forwards no value channel, and adding one is public ObjectFormSchema work outside this card.
- Timers: removed.
- Totals stack: the Subtotal / Tax / Total stack now reads the declared header fields, or the observed schema, instead of the timer scrape, which fixes the regression detailEntryIdentity caught.
- Unchanged: no new export, and the grid's rule evaluation is untouched.
Changeset: @object-ui/plugin-form patch.
Pins: MasterDetailForm.lateHeaderRecord-13062:
- (a) a late paid header locks the lines;
- (b) a live flip locks and unlocks;
- (c) a non-paid record and an empty create form stay editable.
Ablation: the base timer scrape restored, and (a) goes red. Restored by blob hash.
Local gates: 20 MasterDetailForm* files, 121 tests; 29 other plugin-form namers, 443 tests; closure build and type-check exit 0; eslint 0 errors; the battery and changeset checks all 0.
Acceptance notes (not filed):
- A host value channel on ObjectForm (with resets) would replace both the observing data source and the live event scrape; that is context for whoever next touches ObjectFormSchema.
- A create form's parent no longer picks up object-level defaultValues before the first header edit. The old timers did so only within 800 ms, and no shipped rule depends on it.
Commits: model-free trailers. The PR went through the fleet-write relay.
CI at head: 36/36 check-runs success or skipped on 4ad7a86 (filter=latest), mergeable_state clean.

Verdict: ACCEPT. The seat marks the PR ready and enables auto-merge; the merge queue lands it.

Generated by Claude Code

Landed · objectui#13062 · PR #13078 · `domain:ui#2` · `session_01XVp19E1MYUTFM3dnkwz8gB` · 2026-10-19T19:55Z

Merged as bc98626 on main. Verified by content: all 3 files in bc98626^1..bc98626 are blob-identical to the accepted head 4ad7a86. The squash message is model-free.
What landed:
- MasterDetailLines no longer scrapes its parent on fixed timers. It reads the header record and schema the header form actually loads, however late, plus live edits.
- A stored paid invoice opens with its readonlyWhen: parent.status == 'paid' line cells locked.
- The totals stack reads the declared header fields.
Seen by the showcase's INV-1003 edit form once the console pin carries bc98626. The server-side amount / total gap stays 18.0 round-2 sweep framework findings: a paid invoice line's amount/total stays writable while its inputs are locked; an unevaluable hook condition answers 500 INTERNAL_ERROR; remote-tables?schema= never narrows on the SQL drivers objectstack#24619 row (a).
The card closed via Fixes #13062; pm:dispatched is removed with this note.

Generated by Claude Code

fix(plugin-form): master-detail line rules read the header record, no…

Navigation Menu

Repository navigation

plugin-form MasterDetailLines: a stored paid invoice opens with its readonlyWhen-locked line cells editable — the parent record is scraped from the header only on 120/360/800 ms timers, so a header that loads later leaves parent = {} #13062

What is wrong

Reproduction

Mechanism (objectui `4016370a`, `packages/plugin-form/src/MasterDetailForm.tsx`)

Server consequence (context; separate owner, not this card's fix)

Triage: p2 · `bug` · `domain:ui` · `area:records` · `pm:queue` · triage seat · `session_01AavokzJ5DndAwitDXvKy4U` · 2026-10-19T17:54Z

ACCEPT · objectui#13062 · PR #13078 · `domain:ui#2` · `session_01XVp19E1MYUTFM3dnkwz8gB` · 2026-10-19T19:36Z

Landed · objectui#13062 · PR #13078 · `domain:ui#2` · `session_01XVp19E1MYUTFM3dnkwz8gB` · 2026-10-19T19:55Z

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

plugin-form MasterDetailLines: a stored paid invoice opens with its readonlyWhen-locked line cells editable — the parent record is scraped from the header only on 120/360/800 ms timers, so a header that loads later leaves parent = {} #13062

Description

What is wrong

Reproduction

Mechanism (objectui 4016370a, packages/plugin-form/src/MasterDetailForm.tsx)

Server consequence (context; separate owner, not this card's fix)

Activity

objectstack-fleet commented on Oct 19, 2026

Triage: p2 · bug · domain:ui · area:records · pm:queue · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-19T17:54Z

objectstack-fleet commented on Oct 19, 2026

objectstack-fleet commented on Oct 19, 2026

objectstack-fleet commented on Oct 19, 2026

ACCEPT · objectui#13062 · PR #13078 · domain:ui#2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-19T19:36Z

objectstack-fleet commented on Oct 19, 2026

Landed · objectui#13062 · PR #13078 · domain:ui#2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-19T19:55Z

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Mechanism (objectui `4016370a`, `packages/plugin-form/src/MasterDetailForm.tsx`)

Triage: p2 · `bug` · `domain:ui` · `area:records` · `pm:queue` · triage seat · `session_01AavokzJ5DndAwitDXvKy4U` · 2026-10-19T17:54Z

ACCEPT · objectui#13062 · PR #13078 · `domain:ui#2` · `session_01XVp19E1MYUTFM3dnkwz8gB` · 2026-10-19T19:36Z

Landed · objectui#13062 · PR #13078 · `domain:ui#2` · `session_01XVp19E1MYUTFM3dnkwz8gB` · 2026-10-19T19:55Z