Skip to content

chore: centralize comment verification in one reusable workflow - #663

Merged
efraespada merged 3 commits into
developfrom
chore/662-refactor-centralize-native-comment-verification-in-a-reusable-workflow
Oct 21, 2026
Merged

efraespada merged 3 commits into
developfrom
chore/662-refactor-centralize-native-comment-verification-in-a-reusable-workflow

Conversation

@efraespada

@efraespada efraespada commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Comment callbacks copied twenty native verification setup/continue pairs into every source workflow and installed template. Centralize that coordination in one Copilot-owned reusable workflow, leaving 32-line source callbacks and 28-line setup callbacks while retaining the same job, admission, time limits, trusted project setup, continuations and native post cleanup.

Setup retains reviewed runner labels/groups across the job-shape migration and reads effective configuration from known reusable callers. Malformed routing, unknown inputs and unreviewed custom bootstrap fail closed. Internal Action references follow the reusable workflow's exact commit; the upgrade documentation covers runner 2.336.0+, platform/Actions policy, pinned refs and custom bootstrap migration.

Closes #662. Required before release #661; publication remains held until this implementation is merged and reviewed. The two separate release-review corrections are excluded from this PR.

Validation: 710 suites and 11,846 tests passed, with all full-coverage/acceptance gates. The new pure workflow/runner contract has 100% statement, function and branch coverage. Typecheck, lint, specification/documentation/workflow/agent-guide validators, regenerated catalog, reproducible bundles, npm package validation and isolated package smoke passed locally. Hosted Linux, Windows and macOS native acceptance and final-head review must pass before merge.

vypbot and others added 2 commits October 22, 2026 01:04
Keep native setup, continuations and cleanup in one reusable workflow, preserve setup routing and configuration inspection, and document compatible upgrades.
@docs-page

docs-page Bot commented Oct 21, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~663

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review October 21, 2026 23:16
@vypbot vypbot added this to vypdev Oct 21, 2026
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Oct 21, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 21, 2026
@vypbot
vypbot changed the base branch from develop to master October 21, 2026 23:16
@vypbot
vypbot changed the base branch from master to develop October 21, 2026 23:16
@vypbot vypbot added the 75% Progress: 75% label Oct 21, 2026
@vypbot

vypbot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 53567e5.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 53567e5031e1; base: c055c6c9fe31; reason: protected-path.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.82540% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.14%. Comparing base (274db40) to head (53567e5).
⚠️ Report is 1618 commits behind head on develop.

Files with missing lines Patch % Lines
src/utils/setup_workflow_upgrade.ts 90.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #663      +/-   ##
===========================================
+ Coverage    90.94%   94.14%   +3.19%     
===========================================
  Files          135      973     +838     
  Lines         6251    31575   +25324     
  Branches      1338     9265    +7927     
===========================================
+ Hits          5685    29725   +24040     
- Misses         172      715     +543     
- Partials       394     1135     +741     
Files with missing lines Coverage Δ
src/domain/copilot_comment_workflow.ts 100.00% <100.00%> (ø)
...frastructure/setup_management_workspace_adapter.ts 100.00% <100.00%> (ø)
src/utils/setup_installation_review.ts 98.19% <100.00%> (ø)
src/utils/setup_workflow_upgrade.ts 98.01% <90.00%> (ø)

... and 1036 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot findings

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 53567e5. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 4 potential problems when commit 805385a was analyzed. This snapshot is historical; use the status block above for current state. 4 findings are linked to changed code.

Findings

  • high: The runtime references an invalid local action path — .github/workflows/copilot_comment_runtime.yml:78
  • medium: Reusable workflow reference is invalid for GitHub Actions — .github/workflows/copilot_issue_comment.yml:14
  • medium: Validator accepts an invalid GitHub uses reference — scripts/validate-workflow-contract.cjs:159
  • low: Unsupported coordinator refs are silently omitted from installation inspection — src/infrastructure/setup_management_workspace_adapter.ts:91

Comment thread scripts/validate-workflow-contract.cjs Resolved
@efraespada

Copy link
Copy Markdown
Member Author

/copilot dismiss "copilot_comment_runtime.yml:78:invalid-local-action-reference" "copilot_issue_comment.yml:14:invalid-local-reusable-workflow-reference" "scripts/validate-workflow-contract.cjs:159:invalid-current-repository-action-reference"

@vypbot

vypbot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

3 findings were dismissed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

75% Progress: 75% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🔧🧑‍💻 - refactor centralize native comment verification in a reusable workflow

3 participants