Repository navigation
chore: centralize comment verification in one reusable workflow - #663
Conversation
Keep native setup, continuations and cleanup in one reusable workflow, preserve setup routing and configuration inspection, and document compatible upgrades.
|
To preview the documentation for this pull request, visit the following URL:
|
Bugbot: review complete
|
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #663 +/- ##
===========================================
+ Coverage 90.94% 94.14% +3.19%
===========================================
Files 135 973 +838
Lines 6251 31575 +25324
Branches 1338 9265 +7927
===========================================
+ Hits 5685 29725 +24040
- Misses 172 715 +543
- Partials 394 1135 +741
🚀 New features to boost your workflow:
|
|
/copilot findings |
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on53567e5. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 4 potential problems when commit 805385a was analyzed. This snapshot is historical; use the status block above for current state. 4 findings are linked to changed code.
Findings
- high: The runtime references an invalid local action path —
.github/workflows/copilot_comment_runtime.yml:78 - medium: Reusable workflow reference is invalid for GitHub Actions —
.github/workflows/copilot_issue_comment.yml:14 - medium: Validator accepts an invalid GitHub
usesreference —scripts/validate-workflow-contract.cjs:159 - low: Unsupported coordinator refs are silently omitted from installation inspection —
src/infrastructure/setup_management_workspace_adapter.ts:91
|
/copilot dismiss "copilot_comment_runtime.yml:78:invalid-local-action-reference" "copilot_issue_comment.yml:14:invalid-local-reusable-workflow-reference" "scripts/validate-workflow-contract.cjs:159:invalid-current-repository-action-reference" |
|
3 findings were dismissed. |
Comment callbacks copied twenty native verification setup/continue pairs into every source workflow and installed template. Centralize that coordination in one Copilot-owned reusable workflow, leaving 32-line source callbacks and 28-line setup callbacks while retaining the same job, admission, time limits, trusted project setup, continuations and native post cleanup.
Setup retains reviewed runner labels/groups across the job-shape migration and reads effective configuration from known reusable callers. Malformed routing, unknown inputs and unreviewed custom bootstrap fail closed. Internal Action references follow the reusable workflow's exact commit; the upgrade documentation covers runner 2.336.0+, platform/Actions policy, pinned refs and custom bootstrap migration.
Closes #662. Required before release #661; publication remains held until this implementation is merged and reviewed. The two separate release-review corrections are excluded from this PR.
Validation: 710 suites and 11,846 tests passed, with all full-coverage/acceptance gates. The new pure workflow/runner contract has 100% statement, function and branch coverage. Typecheck, lint, specification/documentation/workflow/agent-guide validators, regenerated catalog, reproducible bundles, npm package validation and isolated package smoke passed locally. Hosted Linux, Windows and macOS native acceptance and final-head review must pass before merge.