Skip to content

Face-to-face join/waiting/leave polish: silent disabled Join, frozen countdown, waiting card twice, Leave next to Auto-send and unconfirmed in waiting, held lines shown twice #306

Closed

Description

@Birfy

Summary

Usability and simplicity issues in the Face-to-face join → waiting → leave flow, found in the focus-B self-test. Each item is small; together they make the flow feel heavier and less consistent than the design (one top +, in-chat approval, aesthetics/usability/simplicity/consistency).

Environment

FlyBot main a003044, dsh 0.2.0-rc.2, Node 24. Fresh A :3090 (SelfA1622) / B :3091 (SelfB1622), Bot Social prod (1870786). Self-test 2026-10-18 16:26–16:33 Asia/Shanghai.

Repro

  • → Face-to-face group → pick Chief → type a number → Join → wait → (second home joins) → Enter chat → chat with approvals → Leave. Also: join a number, then Leave from the waiting dialog.

Actual

  1. Join gives no hint. With an empty or short number, Join is disabled (plugins/social/client.js L707: length !== 6), so the Enter a 6-digit number. message (L578–579) can never show. Nothing says why Join is grey.
  2. Countdown looks frozen. It reads 10 minutes left to join and changes once a minute (minute granularity, countdown() L1075–1084). Watched for a while, it looked static.
  3. Dialog chrome.
  4. Leave placement.
  5. Pending Bot lines show twice. Each held Bot line is a full bubble and also a truncated preview inside the approval card below it (Approvals UI: overlay covers the chat bar, every card twice with different words and buttons #260 / Approvals: stale 'waiting for the owner' line in Face-to-face rooms; one place per approval; pointer vs open chat #278 aimed for one place per approval).
  6. "2 members" in details is ambiguous (2 Bots? 2 people?). Same counting issue as the @ picker in Face room @ picker lists a friend's Bot 5 times in 3 sections, 'Everyone · 1 members'; mention chip renders differently per home; Bot named 4 ways #305.

Not filed, checked as by design: re-joining a number whose room already started creates a new room (start deletes the number mapping, Bot Social FACE_ROOMS.md). The top + popover with six items matches #265 / #173.

Expected

  • Join is enabled once a Bot is picked. A wrong number shows the inline Enter a 6-digit number. (or the hint sits under the field while it is incomplete).
  • The countdown ticks visibly: 9:41 left to join, or seconds in the last minutes.
  • One waiting card, in the dialog, with the overlay covering the whole window. The same avatar for a Bot everywhere.
  • Leave sits in the room header or menu, away from toggles. Every Leave asks once (Leave / Stay) and lands on the main Bot.
  • A held line shows once: the bubble with Approve / Reject under it, with no second preview.
  • Counts name what they count: 2 people · 2 Bots.

Activity

  1. Birfy commented on Oct 18, 2026

    @Birfy
    CollaboratorAuthor

    PR #338 covers items 1, 2, 3 (overlay above the details panel, one waiting card, same avatar for my own Bots), 4 (every Leave asks once and lands on the main Bot; in an open room Leave is on the status line, a row away from Auto-send) and 6 (2 people · 2 Bots). Still open here: item 5, a held Bot line shown as a bubble and again as a preview in the approval card. The current tests pin the preview for face_room_message cards, and the owner's own held line has no other place, so this needs a decision on which surface keeps the text.

  2. Birfy commented on Oct 18, 2026

    @Birfy
    CollaboratorAuthor

    Closed as completed, now true on main c6699b7. Items 1, 2, 3, 4 and 6 landed in #338 and item 5 (held Bot line: text in the approval card, the bubble says only "Waiting for approval") in #345. GitHub closed this issue when #345 merged, before #338 had landed. Cross-home avatars stay in #182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions