Skip to content

mcpx: TestNoPackageRedeclaresADefault red on clean main — execsvc/progspec constants bypass defaults.json #3085

New issue
New issue
Closed
#4719
Closed
mcpx: TestNoPackageRedeclaresADefault red on clean main — execsvc/progspec constants bypass defaults.json#3085
#4719
Assignees
dezren39
Labels
app/mcpxPackage/app: mcpx (pkgs/ or apps/ in this repo)effort/sSmall: expected under 2 hours of workkind/bugSomething isn't working (prefixed form of the classic bug label)meta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/normalOrdinary priority (the default)source/queue-workerFiled or worked by the queue/worker pilot

Description

@dezren39
dezren39
opened on Oct 31, 2026

mcpx: TestNoPackageRedeclaresADefault red on clean main — execsvc/progspec constants bypass defaults.json

Evidence (queue task 4303 diagnosis of PR #2888's mcpx-test unit job, run 41167114746, job 124436952405)

TestNoPackageRedeclaresADefault (internal/settings guard) fails on current main:

guard_test.go:138: constants belong in internal/defaults/defaults.json and, where a user could conceivably want them changed, in the settings registry:
      internal/execsvc/hooks.go:63: const hookTimeout = 60 * time.Second
      internal/progspec/progspec.go:232: cmd.WaitDelay = 2 * time.Second
      internal/progspec/progspec.go:41: const DefaultTimeout = 3 * time.Minute

This is one of the 10 top-level unit failures that make PR #2888's mcpx-test ci-ok red (#1998). The sibling settings-guard failures in the same run are already tracked (#2846: ScriptEnv declarations + env doc + TESTING.md compendium + model.* effect probes; #2697; conformance #2695/#2716; e2e/examples destructive-confirm cluster #2896) — this defaults-guard failure has no dedicated issue.

Acceptance criteria

  • The three constants are declared in internal/defaults/defaults.json (and in the settings registry where user-tunable) and read from there; no package-level redeclaration remains.
  • go test ./internal/settings/ -run TestNoPackageRedeclaresADefault passes on clean main.
  • Behavior unchanged: hook timeout 60s, WaitDelay 2s, progspec default timeout 3m remain the effective defaults.

Found by: queue task 4303 (lane F) diagnosing #1998 / PR #2888.

Activity

  1. dezren39
    added
    kind/bugSomething isn't working (prefixed form of the classic bug label)
    app/mcpxPackage/app: mcpx (pkgs/ or apps/ in this repo)
    on Oct 31, 2026

  2. dezren39 commented on Oct 31, 2026

    @dezren39
    dezren39
    on Oct 31, 2026
    MemberAuthor

    Intake review

    🤖 Agent note · filed

    • Agent: fleet monitor
    • Session / ID: repo-fleet-monitor run 2026-10-31 09:12 CDT (intake enrichment)
    • Found via: monitor reconciliation
    • Task: Intake pass — labels normalized, related items linked; acceptance criteria were already present in the body.
    • Expectation: effort/s — move three constants into defaults.json (+ settings registry where user-tunable) and re-run the guard.
    • Links: evidence in the issue body (queue task 4303, PR ci(mcpx): first measured iteration — static e2e shards + unit + lint + ci-ok (#1998) #2888 CI run 41167114746)

    Related: parent diagnosis #1998 / PR #2888 (this is one of its 10 clean-main unit failures); sibling guard failures already tracked in #2846, #2697, #2695/#2716, and the e2e cluster in #2896 — this defaults-guard failure was the untracked remainder.
    Notes: Verified live at intake: no merged PR moves these constants yet; the three sites are named with file:line in the body. Failure is on clean main, so this also reddens unrelated PRs that run the settings guard.
    Risks: Low — behavior-preserving move; the acceptance criteria pin the effective values (60s / 2s / 3m).
    Suggested approach: Declare the three constants in internal/defaults/defaults.json, register the user-tunable one(s) in the settings registry, read from there, and confirm TestNoPackageRedeclaresADefault passes in CI.

  3. dezren39
    added
    priority/normalOrdinary priority (the default)
    effort/sSmall: expected under 2 hours of work
    source/queue-workerFiled or worked by the queue/worker pilot
    status/needs-triageNot yet triaged; needs a first look
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Oct 31, 2026
  4. github-actions
    assigned
    dezren39
    on Oct 31, 2026
  5. dezren39
    added
    work/assignedQueue worker lifecycle state
    queue/claimedQueue worker lifecycle state
    status/in-progressQueue worker lifecycle state
    and removed
    status/needs-triageNot yet triaged; needs a first look
    on Nov 3, 2026

  6. dezren39 commented on Nov 3, 2026

    @dezren39
    dezren39
    on Nov 3, 2026
    MemberAuthor

    agent-note:v1
    task: 6692
    lane: code-l
    transition: picked_up
    state: Task 6692 claimed by lane code-l (direct execution). Implementing the scoped fix: move hookTimeout, cmd.WaitDelay and DefaultTimeout declarations to the defaults source/registry so TestNoPackageRedeclaresADefault passes, keeping effective defaults unchanged (60s / 2s / 3m). Fresh check: issue #3085 OPEN, no hard-stop labels, no existing PR owns this work.

  7. dezren39
    added
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 3, 2026

  8. 3 remaining items

  9. dezren39
    added
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    status/parkedDeliberately paused with a recorded resume condition
    queue/claimedQueue worker lifecycle state
    status/in-progressQueue worker lifecycle state
    and removed
    queue/claimedQueue worker lifecycle state
    status/parkedDeliberately paused with a recorded resume condition
    queue/queuedHas a queued task in the Supabase agent queue
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    on Nov 3, 2026

  10. dezren39 commented on Nov 3, 2026

    @dezren39
    dezren39
    on Nov 3, 2026
    MemberAuthor

    🤖 Agent note · picked up

  11. dezren39
    added a commit that references this issue on Nov 3, 2026

    Merge pull request #4719 from developing-today/queue/6692-3085-mcpx-d…

    2323cbc
  12. dezren39
    closed this as completedin #4719on Nov 3, 2026
  13. dezren39
    removed
    status/in-progressQueue worker lifecycle state
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    on Nov 3, 2026

  14. dezren39 commented on Nov 3, 2026

    @dezren39
    dezren39
    on Nov 3, 2026
    MemberAuthor

    🤖 Agent note · done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/mcpxPackage/app: mcpx (pkgs/ or apps/ in this repo)effort/sSmall: expected under 2 hours of workkind/bugSomething isn't working (prefixed form of the classic bug label)meta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/normalOrdinary priority (the default)source/queue-workerFiled or worked by the queue/worker pilot

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions